fix(Android): getCurrentWifiSSID return null if '<unknown ssid>'

[eliaslecomte]

Sometimes while switching network, android returns .
You aren't connected, so let's simply return an empty string.

[eliaslecomte]

Actually what happens on iOS if you are not connected? Is empty string returned or an exception?

[Rapsssito]

@eliaslecomte, looking at the code:

react-native-wifi-reborn/ios/RNWifi.m

Lines 35 to 46 in 1049665

	- (NSString *) getWifiSSID {
	NSString *kSSID = (NSString*) kCNNetworkInfoKeySSID;
	NSArray *ifs = (__bridge_transfer id)CNCopySupportedInterfaces();
	for (NSString *ifnam in ifs) {
	NSDictionary *info = (__bridge_transfer id)CNCopyCurrentNetworkInfo((__bridge CFStringRef)ifnam);
	if (info[kSSID]) {
	return info[kSSID];
	}
	}
	return nil;
	}

It looks like iOS returns nil when no SSID is found.

[eliaslecomte]

@eliaslecomte, looking at the code:

react-native-wifi-reborn/ios/RNWifi.m

Lines 35 to 46 in 1049665

	- (NSString *) getWifiSSID {
	NSString *kSSID = (NSString*) kCNNetworkInfoKeySSID;
	NSArray *ifs = (__bridge_transfer id)CNCopySupportedInterfaces();
	for (NSString *ifnam in ifs) {
	NSDictionary *info = (__bridge_transfer id)CNCopyCurrentNetworkInfo((__bridge CFStringRef)ifnam);
	if (info[kSSID]) {
	return info[kSSID];
	}
	}
	return nil;
	}

It looks like iOS returns nil when no SSID is found.

Thanks! I've aligned this with Android :-).

[Rapsssito]

@eliaslecomte, taking a deeper look, it looks like when get a null SSID in iOS, we reject the promise with the message "Cannot detect SSID".

react-native-wifi-reborn/ios/RNWifi.m

Lines 183 to 192 in 1049665

	if(self.solved == NO){
	if ([CLLocationManager authorizationStatus] == kCLAuthorizationStatusAuthorizedWhenInUse ||
	[CLLocationManager authorizationStatus] == kCLAuthorizationStatusAuthorizedAlways){
	NSString *SSID = [self getWifiSSID];
	if (SSID){
	resolve(SSID);
	return;
	}
	NSLog(@"RNWIFI:ERROR:Cannot detect SSID");
	reject([ConnectError code:CouldNotDetectSSID], @"Cannot detect SSID", nil);

What do you think? Should we also reject in Android or change the iOS part in order to return null too?

[eliaslecomte]

@Rapsssito I've changed the Android code to also reject in this case.

[JuanSeBestia]

🎉 This PR is included in version 4.3.6 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀