Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type definition #62

Merged
merged 3 commits into from
Apr 19, 2023
Merged

Type definition #62

merged 3 commits into from
Apr 19, 2023

Conversation

Akxe
Copy link
Contributor

@Akxe Akxe commented Apr 19, 2023

Please review if there is some other type for file input. Thanks

@JuanIrache
Copy link
Owner

JuanIrache commented Apr 19, 2023

I'm not qualified to review the TS parts. I can merge this if it doesn't interfere with other things

@Akxe
Copy link
Contributor Author

Akxe commented Apr 19, 2023

I forgot to add return type. Will do and then we can merge tomorrow.

The change to JS is that the function is exported as before and under a named export. This is mainly useful when you import the function and the options side by side...

@Akxe
Copy link
Contributor Author

Akxe commented Apr 19, 2023

To sum it up; You can use the library the same way you used to, but now you have type information fully compatible with what the library can accept.

Also, I added the possibility to import the function as named import. Not that it is needed, but it is a nice to have in TS.

It is ready to be merged :)

@JuanIrache JuanIrache merged commit 385571d into JuanIrache:master Apr 19, 2023
@JuanIrache
Copy link
Owner

Thank you. Merged. Could you make future changes in the dev branch instead of master?

@Akxe
Copy link
Contributor Author

Akxe commented Apr 19, 2023

Will do. Browser compatibility branch is in progress ;)

@Akxe Akxe deleted the type-definition branch April 19, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants