Merge pull request #42 from JuanIrache/dev

Dev
JuanIrache · Feb 25, 2021 · eea18fd · eea18fd
2 parents 2760476 + 6f5b408
commit eea18fd
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/index.js b/index.js
@@ -32,8 +32,8 @@ module.exports = function (file, isBrowser = false, update) {
   var workerRunning = true;
   return new Promise(function (resolve, reject) {
     var readBlock = readBlockFactory();
-    // Providing false gives updates to 100% instead of just 50%
-    mp4boxFile = MP4Box.createFile(false);
+    // Providing false gives updates to 100% instead of just 50%, but seems to fail in Node
+    mp4boxFile = MP4Box.createFile(isBrowser ? false : undefined);
     var uintArr;
     //Will store timing data to help analyse the extracted data
     var timing = {};

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "gpmf-extract",
-  "version": "0.1.22",
+  "version": "0.1.23",
   "description": "Extracts binary GoPro Metadata Format from video files",
   "main": "index.js",
   "scripts": {