Allow Faraday dependency up to v2.0 #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works like a charm, it would be awesome if we can merge it and release an update |
|
Thank you for doing this! Any blockers on releasing this? |
|
@gaorlov What do you think of this? |
Contributor
|
@gaorlov would it be possible to get this PR merged soon? Faraday is changing their API |
Contributor
|
this is great, thanks @gerbal 🚀 any reason why we need the upper constraint, eg |
Collaborator
|
Thanks for your contributions. |
Collaborator
|
I kept it capped under 2.0, because it is unclear what breaking changes forced the major version bump |
JamesGlover
pushed a commit
to sanger/json_api_client
that referenced
this pull request
Apr 13, 2022
- [JsonApiClient#395](JsonApiClient#395) - relaxing faraday dependency to anything less than 2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #394 and allows Faraday versions up to v2.0