Repository navigation
Plugin loading - #325
Open
samuelthomas2774 wants to merge 7 commits into
Open
Plugin loading#325samuelthomas2774 wants to merge 7 commits into
samuelthomas2774 wants to merge 7 commits into
Conversation
samuelthomas2774
commented
Mar 27, 2019
- Patch Module._load to allow plugins to require the plugin API when they load instead of having to wrap every module in a function:
- Add a function to the plugin API to unload everything it keeps track of
- Check external module versions
- Allow plugins and external modules to expose multiple versioned APIs
…stead of wrapping every module in a function
… module that doesn’t exist
…use older versions
Member
|
I like this change, something I wanted to do for awhile. I am at work now so I've only skimmed through it, but I don't see any huge issues. I'll take a closer look tonight when I get home. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.