Skip to content

Issues with Patcher #195

Closed
Closed

Description

@zerebos

Currently the patcher uses IDs for keeping a record of what has been patched using ${displayName}:${functionName}:${caller}. However if a plugin (same caller name) were to use the patcher on two different modules with the same function name the ID might be the same. A large number of internals have switched over to one letter displaynames such as t or repeating displayNames like FluxContainer(t). If a plugin were to try and patch say componentDidMount of multiple of these it would add a child patch to the wrong patch because it would think it's the same module.

The other issues involve checking the return of instead patches or slave patches.

I already have a fixed version of the Patcher that I can PR. I just need to double check existing patches because for some reason they're using hardcoded IDs.

Activity

  1. zerebos commented on Aug 9, 2018

    @zerebos
    MemberAuthor

    Fixed this in #205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions