TypeScript Support

[huan]

Can we rewrite the project in TypeScript, so that we can get the typing support easily?

It will only require some minor changes to the code because we are already using ES6.

If so, I'll be happy to help, for example, send a Pull Request for that.

[julien-f]

Isn't it possible to simply add typedefs to the package?

[huan]

Yes, it's possible.

However, that would make us have to do the additional sync works between the JS and the TypeDefs, and also cannot be benefited from the TypeScript when we develop this package itself.

I'm trying to find a json-rpc package and after did the search work on the Google/NPM, I feel that json-rpc-protocol is great(json-rpc-peer too), except that we are leaking the TypeDefs.

[huan]

In additional:

Since we are already using the Babel to transpile our code, change it to TypeScript will be very smooth, only need a little work, and then we can get all the benefits from the TypeDefs.

[julien-f]

I'm not opposed to a PR with TS code 😛

But the compiled should be ES5.

[huan]

Awesome. I'll try to make a PR with TS code with a tsconfig.json to ES5 target.

Thank you for the acceptance! 😄

[julien-f]

It would be nice if could generate Flow types from TS as well, do you not if that's possible?

[huan]

I had been never used Flow before, but I feel it should be possible to generate Flow Type Def from TS. Will search for it after I finished the TS PR.

[julien-f]

Yep, that's not a priority, it was just a question 🙂

[huan]

Hi Julien, the PR had been submitted, please have a look at it and let me know what you think.

Hope we can enable the typing system soon!

[huan]

Hello, have you had time to review my PR?

Please let me know what you think about it, thanks.

[julien-f]

Released as 0.12.

[huan]

Awesome!