Skip to content

Conversation

@ziesemer
Copy link
Contributor

Notes:

  1. I updated typing_extensions.py to be an exact match of the updated typing.py - as the readme indicates:

As MicroPython has no native typing implementation, the typing_extensions.py module provides identical functionality to the typing.py module.

  1. I'm not sure how the versioning is supposed to work on these, but I updated both to 1.27.0 to match the latest release.
  2. Looks like the prior .mpy files did not even have the version included - but now they do. Not sure what is expected or most appropriate here.

Not sure there are other reasons why this addition should not be included. If accepted, the following should then probably also be looked at for inclusion:

@Josverl Josverl added the typing module typing , typing_extensions and runtime typing label Dec 18, 2025
Copy link
Owner

@Josverl Josverl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
The changes make sense to me , but not sure what happened to the formatting.
Please use Ruff or Black , both should pick up formatting from the project root.

  • Version - I tend to keep aligned to the MicroPython versions where possible. but for typing that is a recent addition, so perhaps that is just an oversight by me.
  • not sure why the version was not in the .mpy , it should not optimized out with mpy-cross -O3 either.

@ziesemer ziesemer requested a review from Josverl December 18, 2025 14:03
- Provides compatibility as introduced with Python 3.12 / PEP 698.
  - https://peps.python.org/pep-0698/
@Josverl Josverl force-pushed the feature/typing-override branch from 9dff822 to 13e1d08 Compare December 18, 2025 16:39
@Josverl Josverl merged commit 974ff05 into Josverl:main Dec 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

typing module typing , typing_extensions and runtime typing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants