Repository navigation
Navigation stack: Ctrl+− / Ctrl+Shift+− back and forward through tab history #52
Description
Summary
Maintain a linear navigation history of tabs and top-level views visited. Ctrl+−
navigates backward and Ctrl+Shift+− (Ctrl+_) navigates forward, analogous to
browser back/forward or Visual Studio Ctrl+−/Ctrl+Shift+−.
Design
See docs/design/navigation-stack.md.
Scope
INavigationHistoryService
- Linear list with current-position pointer (max 200 entries)
Push(NavigationEntry)— called by every tab/view activationGoBack/GoForward— move the pointer, activate the entry- Deduplication: skip push if entry is identical to the one immediately before current
- No persistence — stack is in-memory only
NavigationEntry / TabDescriptor
- Each entry stores: workspace id, tab id, and a
TabDescriptorfor reopening closed tabs TabDescriptorsubclasses per tab kind: entity, agent-session, browser, entity-browser- Closed tab reopen: call
TabDescriptor.OpenAsync; skip and try next on failure
Push sources
MainWindowViewModel.OpenTabAsyncMainWindowViewModeltop-level view selection- Notification click / F7/F8 navigation
- (AI tool integration tracked separately)
Guard against double-push
_navigatingViaHistorybool inMainWindowViewModelsuppresses push during GoBack/GoForward activations
Key bindings
Ctrl+OemMinus→NavigateBackCommandCtrl+Shift+OemMinus→NavigateForwardCommand- Added to
MainWindow.axaml
Acceptance
- Ctrl+− navigates to the previously active tab/view
- Ctrl+Shift+− navigates forward after going back
- Navigating to a new tab while mid-history truncates forward history
- Navigating to a closed tab reopens it; deleted entities are skipped
Activity
Fix #52: navigation stack with Ctrl+−/Ctrl+Shift+−
JoshuaRowePhantom commentedon Jun 30, 2026
Verification failed
Checked: Commit
94354f0(Fix #52) on thefeaturesbranch — filesPhantom.Workspaces/Services/Navigation/INavigationHistoryService.cs,NavigationHistoryService.cs,NavigationEntry.cs,MainWindowViewModel.cs,MainWindow.axaml, and test filePhantom.Workspaces.Tests/NavigationStackTests.cs. Also checked the fullfeaturesbranch tree for any subsequent commits adding the missing pieces.Found:
INavigationHistoryServicewithPush,GoBack,GoForward,CanGoBack,CanGoForwardNavigationHistoryService: linear list, max 200 entries, deduplication, truncation on new push_navigatingViaHistoryguard inMainWindowViewModelCtrl+OemMinus/Ctrl+Shift+OemMinuswired inMainWindow.axamlOpenTabAsync, top-level view selection, and F7/F8 notification navigationMissing:
behaviour not implemented+tests missingTabDescriptorabstract base class —Phantom.Workspaces/Services/Navigation/TabDescriptor.cswith virtualOpenAsync(mainWindowViewModel)is absent. NoEntityTabDescriptor,AgentSessionTabDescriptor, orBrowserTabDescriptorsubclasses exist in the Navigation folder.NavigationEntry.TabDescriptor?field — the current record issealed record NavigationEntry(string TabId, string? WorkspacePaneId)with noTabDescriptor?for closed-tab reopening.ActivateTabById— when a tab is not found in any pane,ActivateTabByIdsilently returns without callingTabDescriptor.OpenAsync. The acceptance criterion "Navigating to a closed tab reopens it; deleted entities are skipped" is not satisfied.NavigationStackTests.cshas no test for the reopen-on-closed-tab or skip-deleted-entity paths.