Repository navigation
Bug: docs/design/notifications.md still describes persisted snooze state after #75 fix #367
Description
Summary
The fix for #75 updated the code and JSON schema correctly, but did not update the design document.
What needs to change in docs/design/notifications.md
-
Line 36 - Remove "Persisted per-tab in the user-computer-profile entity." from the IsSnoozed docstring. Replace with "Snooze state is in-memory only and resets on restart."
-
Lines 159-160 - Remove the persistence paragraph in the Snooze section:
"Snooze state is persisted per tab key in the user-computer-profile entity under a snoozed-notification-tabs string array field."
-
Line 259 - Remove the file checklist entry:
"JsonSchemas/user-computer-profile.json -- add snoozed-notification-tabs string array field"
-
Line 264 - In Non-goals Bump actions/checkout from 4 to 7 #1, change "snooze state is persisted" to "snooze state is not persisted" (or rewrite to clarify it resets on restart).
Why
Issue #75 required removing all design-doc references to persisting snooze state, but the commit only modified the schema file and a code comment. The design doc is the authoritative spec and still documents the wrong behaviour.
Activity
JoshuaRowePhantom commentedon Jun 30, 2026
Design
Root cause: The fix for #75 updated the code and JSON schema to remove persisted snooze state, but left four stale references in \docs/design/notifications.md.
Approach: Update the design doc only — no code changes needed.
Files that will change:
JoshuaRowePhantom commentedon Jun 30, 2026
Tests
This is a documentation-only fix. No tests are needed — there is no code to verify.
JoshuaRowePhantom commentedon Jun 30, 2026
Resolution
Root cause: The fix for #75 updated code and the JSON schema to remove persisted snooze state, but left four stale references in \docs/design/notifications.md\ describing the old persisted behaviour.
Changes:
Deviations from design: None.
Commit: a59e63e
Note: Two pre-existing flaky tests observed during test runs (unrelated to this change): #409, #410.
Fix #367: remove stale snooze-persistence references from notificatio…
JoshuaRowePhantom commentedon Jun 30, 2026
Verification passed
Checked: Commit a59e63e on the \ eatures\ branch, modifying \docs/design/notifications.md.
Result: All four changes described in the issue are present and correctly implemented:
This is a documentation-only fix; no code changes or tests are required.