Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: migrate to create-typescript-app@1 #96

Merged
merged 2 commits into from
Oct 2, 2023
Merged

build: migrate to create-typescript-app@1 #96

merged 2 commits into from
Oct 2, 2023

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

Switches from an internal npm-whoami.d.ts to the published @types/npm-whoami while I'm here.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Sep 5, 2023
Closed
@codecov
Copy link

codecov bot commented Sep 5, 2023 •
edited
Loading

Codecov Report

Merging #96 (01a8c52) into main (545cc3d) will decrease coverage by 4.38%.
The diff coverage is 94.11%.

@@             Coverage Diff             @@
##              main      #96      +/-   ##
===========================================
- Coverage   100.00%   95.62%   -4.38%     
===========================================
  Files            9       12       +3     
  Lines           51      343     +292     
  Branches        11       30      +19     
===========================================
+ Hits            51      328     +277     
- Misses           0       15      +15
Files Coverage Δ
src/assertValidOwnership.ts 100.00% <100.00%> (ø)
src/createUserPackagesFilter.ts 100.00% <100.00%> (ø)
src/fakes.ts 100.00% <100.00%> (ø)
src/getNpmUserPackages.ts 100.00% <100.00%> (ø)
src/getPackageEstimates.ts 100.00% <100.00%> (ø)
src/reporters/textReporter.ts 100.00% <100.00%> (ø)
src/tideliftMeUp.ts 95.45% <100.00%> (ø)
src/tideliftMeUpCli.ts 100.00% <100.00%> (ø)
src/types.ts 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JoshuaKGoldberg JoshuaKGoldberg merged commit 69420d4 into main Oct 2, 2023
11 of 13 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the create-typescript-app-1 branch October 2, 2023 17:20
@JoshuaKGoldberg
Copy link
Owner Author

@all-contributors please add @JoshuaKGoldberg for infra.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors allcontributors bot mentioned this pull request Oct 2, 2023
Merged
@allcontributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @JoshuaKGoldberg! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

JoshuaKGoldberg pushed a commit that referenced this pull request Oct 2, 2023
@allcontributors
docs: add joshuakgoldberg as a contributor for infra (#106)
862f54d 
Adds @JoshuaKGoldberg as a contributor for infra.

This was requested by JoshuaKGoldberg [in this
comment](#96 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🛠 Tooling: Migrate to create-typescript-app@1
1 participant
@JoshuaKGoldberg