Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Add rule for shorthand repository for GitHub repos #71

Closed
3 tasks done
azat-io opened this issue Nov 28, 2023 · 4 comments · Fixed by #70
Closed
3 tasks done

🚀 Feature: Add rule for shorthand repository for GitHub repos #71

azat-io opened this issue Nov 28, 2023 · 4 comments · Fixed by #70
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Milestone
Full Recommended ...

Comments

@azat-io
Copy link
Contributor

azat-io commented Nov 28, 2023

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

If you are using GitHub, you can use short version in package.json to provide a link to the repository.
Read more:
npm/npm#3783

Additional Info

I created PR #70
@azat-io azat-io added the type: feature New enhancement or request label Nov 28, 2023
@azat-io azat-io mentioned this issue Nov 28, 2023
Merged
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg added the status: accepting prs Please, send a pull request to resolve this! label Dec 11, 2023
@JoshuaKGoldberg
Copy link
Owner

Whoa, TIL! Thanks for filing 😄

@JoshuaKGoldberg
Copy link
Owner

@all-contributors please add @azat-io for ideas.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors allcontributors bot mentioned this issue Jan 20, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @azat-io! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

JoshuaKGoldberg added a commit that referenced this issue Jan 20, 2024
@allcontributors @JoshuaKGoldberg
docs: add azat-io as a contributor for ideas (#105)
133bd48 
Adds @azat-io as a contributor for ideas.

This was requested by JoshuaKGoldberg [in this
comment](#71 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
JoshuaKGoldberg added a commit that referenced this issue Jan 20, 2024
@azat-io @JoshuaKGoldberg
feat: add prefer-repository-shorthand rule (#70)
0c7fb19 
<!-- 👋 Hi, thanks for sending a PR to eslint-plugin-package-json! 💖.
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->

## PR Checklist

-   [x] Addresses an existing open issue: fixes #71
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Added new rule for shortened GitHub repo urls declaration.

---------

Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
@github-actions GitHub Actions
Copy link

🎉 This is included in version v0.5.0 🎉

The release is available on:

Cheers! 📦🚀

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jan 28, 2024
Open
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Feb 12, 2024
Merged
This was referenced Mar 19, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
Full Recommended Config
Development

Successfully merging a pull request may close this issue.

feat: add prefer-repository-shorthand rule azat-io/eslint-plugin-package-json
2 participants
@JoshuaKGoldberg @azat-io