Skip to content

feat: add create flow and unify bin with --mode #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Aug 22, 2023
Merged

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Aug 22, 2023

PR Checklist

Overview

Changes the bin script to be the main launching point for the app. It can take in or prompt for a --mode set to either "create", "initialize", or "migrate".

This comes with a few cleanups:

  • Simplified runOrRestore so that it just runs or logs - leaving parsing logic to the functions that call it
  • Removed a lot of the terminal logs so that the remaining output is cleaner
  • Cleaned up input parsing to have fewer different code paths / types

Tracking my todo items:

  • Add a new create flow alongside initialize and migrate
  • Manually test a bunch
  • Refactor their code to streamline the flow of logic
  • Fix unit tests
  • Fix existing end-to-end tests
  • Overhaul documentation
  • Add a new end-to-end test
  • Manually test some more

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@JoshuaKGoldberg JoshuaKGoldberg changed the title [WIP] feat: add create flow and unify bin with --mode feat: add create flow and unify bin with --mode Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #681 (842741a) into main (556ea3a) will increase coverage by 6.71%.
Report is 1 commits behind head on main.
The diff coverage is 44.75%.

@@            Coverage Diff             @@
##             main     #681      +/-   ##
==========================================
+ Coverage   56.32%   63.03%   +6.71%     
==========================================
  Files          64       77      +13     
  Lines         403      487      +84     
  Branches       77       83       +6     
==========================================
+ Hits          227      307      +80     
- Misses        165      169       +4     
  Partials       11       11              
Flag Coverage Δ
create 94.11% <100.00%> (?)
initialize 94.11% <100.00%> (∅)
migrate 100.00% <100.00%> (ø)
unit 59.40% <43.50%> (+3.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/create/createWithValues.ts 0.00% <0.00%> (ø)
src/create/index.ts 0.00% <0.00%> (ø)
src/initialize/index.ts 0.00% <0.00%> (ø)
src/initialize/initializeWithValues.ts 0.00% <0.00%> (ø)
src/migrate/index.ts 0.00% <0.00%> (ø)
src/migrate/migrateWithValues.ts 0.00% <0.00%> (ø)
src/migrate/values/readAuthorIfExists.ts 100.00% <ø> (ø)
src/migrate/values/readEmailIfExists.ts 100.00% <ø> (ø)
src/shared/args.ts 0.00% <0.00%> (ø)
src/shared/augmentValuesWithNpmInfo.ts 0.00% <0.00%> (ø)
... and 54 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JoshuaKGoldberg JoshuaKGoldberg merged commit edd4d8f into main Aug 22, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the add-create-flow branch August 22, 2023 19:58
@github-actions
Copy link

🎉 This is included in version v1.29.1 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Be able to initialize a new repository on the CLI (like create-* apps)
1 participant