Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onboard eslint-plugin-package-json #1269

Merged
merged 3 commits into from
Jan 20, 2024

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

Directly swaps from the standalone npm-package-json-lint linter to using eslint-plugin-package-json in the existing ESLint config. Fewer tools, yay!

Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (25fb5e5) 94.80% compared to head (e86a36d) 94.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1269      +/-   ##
==========================================
- Coverage   94.80%   94.79%   -0.01%     
==========================================
  Files         103      103              
  Lines        5799     5788      -11     
  Branches      492      491       -1     
==========================================
- Hits         5498     5487      -11     
  Misses        300      300              
  Partials        1        1              
Flag Coverage Δ
create 69.97% <72.22%> (-0.08%) ⬇️
initialize 42.35% <27.77%> (+0.11%) ⬆️
migrate 69.80% <66.66%> (-0.06%) ⬇️
unit 75.69% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 592b0c8 into main Jan 20, 2024
15 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the eslint-plugin-package-json branch January 20, 2024 22:58
Copy link

🎉 This is included in version v1.56.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Switch from npm-package-json-lint to eslint-plugin-package-json
1 participant