Skip to content

🐛 Bug: Feature issue template asks about pulling from main, weirdly #2217

@JoshuaKGoldberg

Description

@JoshuaKGoldberg

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

Each issue template should have fields relevant to just that type of issue. They also all ask to make sure you're looking at the current version of the thing in question. For the feature request template, I'd think it should ask that users are on the latest version of the package. Maybe:

- label: I have verified I've installed the latest version of the package
  required: true

Actual

Coming over from JoshuaKGoldberg/formatly#123 (comment):

Off topic: Creating new feature request has check "I have pulled the latest main branch of the repository.*" which feels weird, because I'm not cloning this repository to try this tool. I'm using it with npx / wishing new feature based on documentation.

- label: I have pulled the latest `main` branch of the repository.
required: true

Agreed 😄. It's a holdover from "adopting" the template from other places (read: copy & pasting).

Additional Info

This is a good first issue because it's a pretty direct example of the places you'd need to change logic for a single Block:

  • .github/ISSUE_TEMPLATE/03-feature.yml
  • src/blocks/blockGitHubIssueTemplates.ts
  • src/blocks/blockGitHubIssueTemplates.test.ts (which I normally auto-update with pnpm run test -u)

Co-authored-by: @rubiesonthesky

🎁

Metadata

Metadata

Labels

good first issueGood for newcomers, please hop on!status: accepting prsPlease, send a pull request to resolve this!type: bugSomething isn't working :(

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions