Skip to content

Remove uses of System.ValueTuple #2324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/CsvHelper/Configuration/ClassMap`1.cs
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public ClassMap() : base(typeof(TClass)) { }
/// <returns>The member mapping.</returns>
public virtual MemberMap<TClass, TMember> Map<TMember>(Expression<Func<TClass, TMember?>> expression, bool useExistingMap = true)
{
var (classMap, member) = GetMemberMap(expression);
var classMap = GetMemberMap(expression, out var member);
var memberMap = classMap.Map(typeof(TClass), member, useExistingMap); ;

return (MemberMap<TClass, TMember>)memberMap;
Expand All @@ -42,7 +42,7 @@ public virtual MemberMap<TClass, TMember> Map<TMember>(Expression<Func<TClass, T
/// <returns>The member mapping.</returns>
public virtual MemberMap Map<T>(Expression<Func<T, object?>> expression, bool useExistingMap = true)
{
var (classMap, member) = GetMemberMap(expression);
var classMap = GetMemberMap(expression, out var member);
var memberMap = classMap.Map(typeof(TClass), member, useExistingMap);

return memberMap;
Expand All @@ -64,7 +64,7 @@ public virtual MemberReferenceMap References<TClassMap>(Expression<Func<TClass,
return References(typeof(TClassMap), member, constructorArgs);
}

private (ClassMap, MemberInfo) GetMemberMap<TModel, TProperty>(Expression<Func<TModel, TProperty?>> expression)
private ClassMap GetMemberMap<TModel, TProperty>(Expression<Func<TModel, TProperty?>> expression, out MemberInfo member)
{
var stack = ReflectionHelper.GetMembers(expression);
if (stack.Count == 0)
Expand All @@ -73,7 +73,6 @@ public virtual MemberReferenceMap References<TClassMap>(Expression<Func<TClass,
}

ClassMap currentClassMap = this;
MemberInfo member;

if (stack.Count > 1)
{
Expand Down Expand Up @@ -105,6 +104,6 @@ public virtual MemberReferenceMap References<TClassMap>(Expression<Func<TClass,
// Add the member map to the last reference map.
member = stack.Pop();

return (currentClassMap, member);
return currentClassMap;
}
}
34 changes: 30 additions & 4 deletions src/CsvHelper/CsvReader.cs
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public class CsvReader : IReader
private readonly Lazy<RecordManager> recordManager;
private readonly bool detectColumnCountChanges;
private readonly Dictionary<string, List<int>> namedIndexes = new Dictionary<string, List<int>>();
private readonly Dictionary<string, (string, int)> namedIndexCache = new Dictionary<string, (string, int)>();
private readonly Dictionary<string, NameIndex> namedIndexCache = new Dictionary<string, NameIndex>();
private readonly Dictionary<Type, TypeConverterOptions> typeConverterOptionsCache = new Dictionary<Type, TypeConverterOptions>();
private readonly MemberMapData reusableMemberMapData = new MemberMapData(null);
private readonly bool hasHeaderRecord;
Expand Down Expand Up @@ -1276,8 +1276,7 @@ public virtual int GetFieldIndex(IEnumerable<string> names, int index = 0, bool
var nameKey = string.Join("_", names) + index;
if (namedIndexCache.TryGetValue(nameKey, out var cache))
{
(var cachedName, var cachedIndex) = cache;
return namedIndexes[cachedName][cachedIndex];
return namedIndexes[cache.Name][cache.Index];
}

// Check all possible names for this field.
Expand Down Expand Up @@ -1310,7 +1309,7 @@ public virtual int GetFieldIndex(IEnumerable<string> names, int index = 0, bool
return -1;
}

namedIndexCache.Add(nameKey, (name, index));
namedIndexCache.Add(nameKey, new NameIndex(name, index));

return namedIndexes[name][index];
}
Expand Down Expand Up @@ -1435,4 +1434,31 @@ protected virtual void ParseNamedIndexes()
}
}
}

private readonly struct NameIndex : IEquatable<NameIndex>
{
public string Name { get; }
public int Index { get; }

public NameIndex(string name, int index)
{
Name = name;
Index = index;
}

public override bool Equals(object? obj)
{
return obj is NameIndex index && Equals(index);
}

public bool Equals(NameIndex other)
{
return Name == other.Name && Index == other.Index;
}

public override int GetHashCode()
{
return HashCode.Combine(Name, Index);
}
}
}
Loading