Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reader file format ipynb #1284

Merged
merged 9 commits into from
Dec 9, 2024
Merged

add reader file format ipynb #1284

merged 9 commits into from
Dec 9, 2024

Conversation

birdup000
Copy link
Contributor

@birdup000 birdup000 commented Nov 25, 2024

Fixes crash thread crash when trying to read ipynb files

Types of changes

Changes visible to users:

  • Bug fix (prefix: fix - non-breaking change which fixes an issue)
  • New feature (prefix: feat - non-breaking change which adds functionality)
  • Breaking change (prefix: feat!! or fix!! - fix or feature that would cause existing functionality to not work as expected)

Internal changes:

  • Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behavior)
  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)
  • Infrastructure (prefix: chore - examples include GitHub Actions, issue templates)

Checklist

  • My change requires a change to the documentation.
  • My change works!

The get_step_response method in the Chain class was raising a KeyError when attempting to access the "id" key from chain_data because chain_data was an empty list instead of a dictionary. This scenario occurs when the chain is not found.

Signed-off-by: Birdup <34012548+birdup000@users.noreply.github.com>
@birdup000 birdup000 marked this pull request as ready for review November 25, 2024 21:13
@birdup000 birdup000 marked this pull request as draft November 25, 2024 21:49
Signed-off-by: Birdup <34012548+birdup000@users.noreply.github.com>
Signed-off-by: Birdup <34012548+birdup000@users.noreply.github.com>
Signed-off-by: Birdup <34012548+birdup000@users.noreply.github.com>
@birdup000 birdup000 changed the title Fix: Handle empty list in get_step_response for missing chain data Fix a few things and add reader file format ipynb Nov 25, 2024
Josh-XT and others added 2 commits November 30, 2024 04:18
Signed-off-by: Birdup <34012548+birdup000@users.noreply.github.com>
@birdup000 birdup000 changed the title Fix a few things and add reader file format ipynb add reader file format ipynb Dec 5, 2024
@birdup000 birdup000 marked this pull request as ready for review December 5, 2024 01:27
birdup000 and others added 3 commits December 4, 2024 19:29
Signed-off-by: Birdup <34012548+birdup000@users.noreply.github.com>
@Josh-XT Josh-XT merged commit 9c6e9ec into Josh-XT:main Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants