Skip to content

Fix: File permissions - #31

Merged
JosephMaynard merged 3 commits into
masterfrom
fix/file-permissions
May 2, 2026
Merged

JosephMaynard merged 3 commits into
masterfrom
fix/file-permissions

Conversation

@JosephMaynard

@JosephMaynard JosephMaynard commented May 2, 2026 •

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • New Features

    • Added validation checks for package distribution integrity.
  • Bug Fixes

    • Fixed CLI executable permissions.
  • Style

    • Updated dark theme styling with refined header colors, adjusted button dimensions, and improved spacing.

@coderabbitai

coderabbitai Bot commented May 2, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 87e543f4-0b5f-423c-a14f-cc78697e111c

📥 Commits

Reviewing files that changed from the base of the PR and between 5ec0d3d and b8b8523.

⛔ Files ignored due to path filters (4)
  • dist/cli.js is excluded by !**/dist/**
  • dist/report-assets.js is excluded by !**/dist/**
  • package-lock.json is excluded by !**/package-lock.json
  • report-ui/dist/report.css is excluded by !**/dist/**
📒 Files selected for processing (4)
  • package.json
  • report-ui/style.css
  • scripts/check-pack.js
  • src/report-assets.ts

📝 Walkthrough

Walkthrough

This PR adds build-time execute permission verification for the CLI, introduces a pack validation tool to ensure proper tarball metadata, and updates UI styling by removing a gradient definition, adjusting CTA component styling, and regenerating embedded CSS assets.

Changes

Build & Pack Verification

Layer / File(s) Summary
Build Configuration & Scripts
package.json
build script appends chmodSync('dist/cli.js', 0o755) after tsc. test:pack changes from npm pack --dry-run to node scripts/check-pack.js.
Pack Validation Logic
scripts/check-pack.js
New utility script runs npm pack --dry-run --json, validates packument metadata, confirms dist/cli.js exists, and verifies execute permission bits on the tarball entry.

UI Styling Updates

Layer / File(s) Summary
Source CSS Styling
report-ui/style.css
Dark theme removes --title-gradient; .header-text h1 uses --accent instead. .cta-card padding reduced on left edge; .cta-icon adds background-color: var(--bg-primary); .cta-button border-radius decreased from 12px to 10px.
Generated Assets
src/report-assets.ts
CSS_CONTENT regenerated to reflect source CSS styling changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Poem

🐰 The chmod hops along the build,
A tiny script so neatly filled,
With execute bits now in place,
And CSS dressed with style and grace!
✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title 'Fix: File permissions' is overly narrow and misleading. While file permissions are addressed in package.json, the changeset includes significant style updates (CSS modifications), a new validation script, and generated content changes that are not reflected in the title. Consider a more comprehensive title that captures the main changes, such as 'Update build process, styling, and add pack validation' or similar to better reflect the full scope of modifications.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/file-permissions

Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@JosephMaynard
JosephMaynard merged commit 5a9fad9 into master May 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant