Repository navigation
Feat: Exit Codes #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feat: Exit Codes #18
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1e5272f
Add fail-on flag handling
JosephMaynard a24ce2e
Add fail-on flag exit policy
JosephMaynard f70ead4
Add fail-on policy flag
JosephMaynard 16bcda3
Update README and cli summaries
JosephMaynard a889704
Address CodeRabbit comment
JosephMaynard c495232
Add CLI fail-on integration test
JosephMaynard 8a03fd6
Update README and cli tests
JosephMaynard e161d24
📝 Add docstrings to `feat/exit-codes`
coderabbitai[bot] 2b11cef
Add fail-on integration test
JosephMaynard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,118 @@ | ||
| import { spawnSync } from 'child_process'; | ||
| import path from 'path'; | ||
| import { describe, expect, it } from 'vitest'; | ||
|
|
||
| const ANSI_ESCAPE_REGEX = new RegExp('\\x1b\\[[0-9;]*[A-Za-z]', 'g'); | ||
|
|
||
| function stripAnsi(value: string): string { | ||
| return value.replace(ANSI_ESCAPE_REGEX, ''); | ||
| } | ||
|
|
||
| describe('cli summary output', () => { | ||
| it( | ||
| 'prints summary bullets and keeps CTA as the final line', | ||
| { timeout: 30000 }, | ||
| () => { | ||
| const repoRoot = path.resolve(__dirname, '..'); | ||
| const tsNodeBin = path.join( | ||
| repoRoot, | ||
| 'node_modules', | ||
| 'ts-node', | ||
| 'dist', | ||
| 'bin.js', | ||
| ); | ||
| const cliPath = path.join(repoRoot, 'src', 'cli.ts'); | ||
|
|
||
| const result = spawnSync( | ||
| process.execPath, | ||
| [tsNodeBin, cliPath, 'scan', '--project', repoRoot, '--offline', '--no-report'], | ||
| { | ||
| cwd: repoRoot, | ||
| encoding: 'utf8', | ||
| env: { | ||
| ...process.env, | ||
| NO_COLOR: '1', | ||
| }, | ||
| }, | ||
| ); | ||
|
|
||
| expect(result.status).toBe(0); | ||
|
|
||
| const output = stripAnsi(`${result.stdout}\n${result.stderr}`).replace(/\r/g, ''); | ||
| const stdoutOutput = stripAnsi(result.stdout).replace(/\r/g, ''); | ||
|
|
||
| expect(output).toContain('Summary:'); | ||
| expect(output).toMatch(/• Direct deps scanned: \d+/); | ||
| expect(output).toMatch(/• Transitive deps scanned: \d+/); | ||
| expect(output).toMatch(/• Vulnerable packages: \d+ \(\d+ reachable\)/); | ||
| expect(output).toMatch(/• Unused installed deps: \d+/); | ||
| expect(output).toMatch(/• License mismatches: \d+/); | ||
| expect(output).toMatch(/• Major upgrade blockers: \d+/); | ||
|
|
||
| const blockerTotalMatch = output.match(/• Major upgrade blockers: (\d+)/); | ||
| const blockerTotal = blockerTotalMatch | ||
| ? Number.parseInt(blockerTotalMatch[1], 10) | ||
| : 0; | ||
| if (blockerTotal > 0) { | ||
| expect(output).toMatch(/^\s{3}- \d+ .+/m); | ||
| } | ||
|
|
||
| expect(output).toContain( | ||
| 'Enrich this scan with maintenance signals, upgrade readiness, and risk modelling at dependency-radar.com', | ||
| ); | ||
| expect(stdoutOutput.trim().endsWith( | ||
| 'Enrich this scan with maintenance signals, upgrade readiness, and risk modelling at dependency-radar.com', | ||
| )).toBe(true); | ||
| }, | ||
| ); | ||
|
|
||
| it( | ||
| 'exits non-zero and prints policy violations when --fail-on is triggered', | ||
| { timeout: 30000 }, | ||
| () => { | ||
| const repoRoot = path.resolve(__dirname, '..'); | ||
| const tsNodeBin = path.join( | ||
| repoRoot, | ||
| 'node_modules', | ||
| 'ts-node', | ||
| 'dist', | ||
| 'bin.js', | ||
| ); | ||
| const cliPath = path.join(repoRoot, 'src', 'cli.ts'); | ||
| const fixtureProject = path.join( | ||
| repoRoot, | ||
| 'test-fixtures', | ||
| 'license-edge-cases', | ||
| ); | ||
|
|
||
| const result = spawnSync( | ||
| process.execPath, | ||
| [ | ||
| tsNodeBin, | ||
| cliPath, | ||
| 'scan', | ||
| '--project', | ||
| fixtureProject, | ||
| '--offline', | ||
| '--no-report', | ||
| '--fail-on', | ||
| 'licence-mismatch', | ||
| ], | ||
| { | ||
| cwd: repoRoot, | ||
| encoding: 'utf8', | ||
| env: { | ||
| ...process.env, | ||
| NO_COLOR: '1', | ||
| }, | ||
| }, | ||
| ); | ||
|
|
||
| expect(result.status).toBe(1); | ||
|
|
||
| const output = stripAnsi(`${result.stdout}\n${result.stderr}`).replace(/\r/g, ''); | ||
| expect(output).toContain('Policy violations detected'); | ||
| expect(output).toContain('licence mismatch'); | ||
| }, | ||
| ); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.