Merged
Conversation
jongfeel
reviewed
Mar 28, 2021
Collaborator
jongfeel
left a comment
jongfeel
left a comment
There was a problem hiding this comment.
Player class 정의를 해보면 좋을 것 같습니다.
이 class만 잘 정의해도 꽤 그럴싸하게 시뮬레이션 할 수 있는 테스트도 가능해집니다.
Co-authored-by: Kim Jong Feel <DeveloperFEEL@gmail.com>
Owner
Author
|
우선 플레이어 생성과 관련된 것에 한해서 설계문 작성했습니다. 말씀해주신 Player class 부분은 다음 단계에서 구체적으로 작성하겠습니다. 그리고 데이터와 행위 부분을 따로 따로 작성했던 부분을(DataManager와 GameManager) GameManager에 통합해서 관리하려고 합니다. |
jongfeel
approved these changes
Apr 4, 2021
Collaborator
jongfeel
left a comment
jongfeel
left a comment
There was a problem hiding this comment.
여기까지 좋은 것 같습니다.
Player class 코드를 작성해 보고 또 변경 사항들을 판단해서 계속 수정 보완해 나가면 좋을 것 같네요.
Owner
Author
|
네넹! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
캐릭터 생성과 관련된 설계 내용입니다.
장기적으로 봤을 때 부수적인 데이터를 저장하는 클래스(DataManager)와 플레이어 정보를 저장하는 PlayerData 클래스가 필요할 것 같아서 우선 데이터를 저장하고 불러오는 방식으로 설계를 했습니다.