Skip to content

Initialise JavaScript listeners once per page load #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Initialise JavaScript listeners once per page load #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions filter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,6 @@ class filter_tabs extends moodle_text_filter {
*/
const PLACEHOLDER_PATTERN = '/\{%:([^}]*)\}(.*?)\{%\}/s';

/**
* Page.
*
* @var moodle_page $page.
*/
private $page;

/**
* Plugin renderer.
*
Expand All @@ -56,8 +49,9 @@ class filter_tabs extends moodle_text_filter {
* @param context $context The current context.
*/
public function setup($page, $context) {
$this->page = $page;
$page->requires->js_call_amd('filter_tabs/tabs', 'init');
if ($page->requires->should_create_one_time_item_now('filter_tabs/setup')) {
$page->requires->js_call_amd('filter_tabs/tabs', 'init');
}
}

/**
Expand Down Expand Up @@ -112,8 +106,10 @@ private function replace_text(string $text, array $matches) {
* @return string
*/
private function generate_tabs(array $matches) {
global $PAGE;

if ($this->renderer === null) {
$this->renderer = $this->page->get_renderer('filter_tabs');
$this->renderer = $PAGE->get_renderer('filter_tabs');
}

$config = config::create(get_config('filter_tabs'));
Expand Down