Merge pull request ipfs/go-bitswap#508 from ipfs/fix/disconnect-data-…

…race fix(decision): fix a datarace on disconnect This commit was moved from ipfs/go-bitswap@5f2fd63
Jorropo · Jun 24, 2021 · 1f14023 · 1f14023
2 parents ec8d143 + ad9db9b
commit 1f14023
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/bitswap/internal/decision/engine.go b/bitswap/internal/decision/engine.go
@@ -703,7 +703,11 @@ func (e *Engine) PeerDisconnected(p peer.ID) {
 
 	ledger, ok := e.ledgerMap[p]
 	if ok {
-		for _, entry := range ledger.Entries() {
+		ledger.lk.RLock()
+		entries := ledger.Entries()
+		ledger.lk.RUnlock()
+
+		for _, entry := range entries {
 			e.peerLedger.CancelWant(p, entry.Cid)
 		}
 	}