Skip to content

Comments

fix: Fix argument parsing if params are present e.g. {RandomNumber(2,4)}#12

Open
das-peter wants to merge 1 commit intoJordiGiros:masterfrom
das-peter:fix/fix-argument-parsing-with-params
Open

fix: Fix argument parsing if params are present e.g. {RandomNumber(2,4)}#12
das-peter wants to merge 1 commit intoJordiGiros:masterfrom
das-peter:fix/fix-argument-parsing-with-params

Conversation

@das-peter
Copy link
Contributor

Just stumbled over the fact that the argument parsing seems to fail if the argument contains params.
Example:
When I fill in "field1" with "{RandomNumber(2,4)}"
Will result in a value of "{RandomNumber(2,4)}" because \Transformation\Argument::supportsDefinitionAndArgument() will not recognize the argument as valid "function".
This is due to a to restrictive regexp in \Transformation\Argument::SLOT_NAME_REGEX.
This PR adjusts the related pattern and expands the test suite to catch this type of error.
If you run the test suite without the pattern adjustment it will fail, and it will completely pass once the pattern has been adjusted.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant