Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete season or episode if they are deleted in TMDB #72

Open
2 of 3 tasks
JoosepAlviste opened this issue Aug 13, 2023 · 0 comments
Open
2 of 3 tasks

Delete season or episode if they are deleted in TMDB #72

JoosepAlviste opened this issue Aug 13, 2023 · 0 comments
Labels

Comments

@JoosepAlviste
Copy link
Owner

JoosepAlviste commented Aug 13, 2023

For example, season 9 of Futurama was deleted in TMDB: https://api.themoviedb.org/3/tv/615/season/9

In this case, we should delete the season and episodes from the database.

We should handle cases where:

  • A series is deleted
  • A season is deleted
  • An episode is deleted
@JoosepAlviste JoosepAlviste added this to the Improvements 1 milestone Aug 13, 2023
JoosepAlviste added a commit that referenced this issue Aug 13, 2023
This requires some refactoring of the TMDB request making as we want to
differentiate between a not found response and if parsing fails. If the
parsing fails, then that is not enough cause to delete the series as
there might just be some random breaking change that we would need to
handle. In the future, we should probably send a Sentry error or
something when parsing fails.

Related to #72
JoosepAlviste added a commit that referenced this issue Aug 14, 2023
We have to be careful not to delete the season in case of a parsing
error as there may have just been a breaking change in the TMDB API.

Related to #72
JoosepAlviste added a commit that referenced this issue Oct 4, 2023
This is not quite final, there are some cases which haven't been tested.

Related to #72
JoosepAlviste added a commit that referenced this issue Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant