Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/activate eslint import type checking #657

Merged
merged 1 commit into from
Aug 17, 2024
Merged

feat/activate eslint import type checking #657

merged 1 commit into from
Aug 17, 2024

Conversation

PatrykKuniczak
Copy link
Collaborator

* Please fill in the required items.

Priority*

  • High: This PR needs to be merged first for other tasks.
  • Middle: This PR should be merged quickly to prevent conflicts due to common changes. (default)
  • Low: This PR does not affect other tasks, so it can be merged later.

Purpose of the PR*

It's good to have type imports and rest, separated

Changes*

How to check the feature

Try to import without 'type' a type import

@PatrykKuniczak PatrykKuniczak added the enhancement New feature or request label Aug 15, 2024
Jonghakseo
Jonghakseo approved these changes Aug 17, 2024
View reviewed changes
Copy link
Owner

@Jonghakseo Jonghakseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jonghakseo Jonghakseo merged commit 8fe30f2 into main Aug 17, 2024
5 checks passed
@Jonghakseo Jonghakseo deleted the feat/eslint-import-checking branch August 17, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jonghakseo Jonghakseo Jonghakseo approved these changes

Assignees

@PatrykKuniczak PatrykKuniczak

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PatrykKuniczak @Jonghakseo