Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/create config for eslint, commitlint, prettier and husky (#181) #197

Merged
merged 6 commits into from
Oct 18, 2023
Merged

Feat/create config for eslint, commitlint, prettier and husky (#181) #197

merged 6 commits into from
Oct 18, 2023

Conversation

PatrykKuniczak
Copy link
Collaborator

@PatrykKuniczak PatrykKuniczak commented Oct 11, 2023

As i say, i do it #181

Here's i run this command, and many files have changes, everything works fine

The single quote is my personal preferences, cause less place is wasted, if u think double is better for this boilerplate, you can change it :)

Merge this after #196
I can rebase it and run prettier, then all files have new formatting :)

@PatrykKuniczak PatrykKuniczak changed the title Feat/create config for eslint, commitlint, prettier and husky Feat/create config for eslint, commitlint, prettier and husky (#181) Oct 13, 2023
Copy link
Owner

@Jonghakseo Jonghakseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't disagree with anything else, but I personally don't like the useTabs in the prettier setting because I see a lot of unnecessary whitespace when I look at the code on github. I also think it causes a lot of unnecessary filechanges to be logged. For both of those reasons, it would be nice if that item could be modified to false lol.

@PatrykKuniczak
Copy link
Collaborator Author

@Jonghakseo You're right, this tabs is unnecessary, i also remove it in my project :)

And i configure wrong, cause eslint have conflict with prettier, now it's good :)

Copy link
Owner

@Jonghakseo Jonghakseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jonghakseo Jonghakseo merged commit 07c48ae into Jonghakseo:main Oct 18, 2023
@PatrykKuniczak PatrykKuniczak deleted the feat/eslint-prettier-husky branch October 18, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants