Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically select XZ BCJ filter #54

Merged
merged 2 commits into from
Jul 16, 2017
Merged

Dynamically select XZ BCJ filter #54

merged 2 commits into from
Jul 16, 2017

Conversation

JonathonReinhart
Copy link
Owner

Closes #53

@JonathonReinhart
Copy link
Owner Author

JonathonReinhart commented Jul 16, 2017

This is failing because SCons raised an exception:

ImportError: No module named backports:

pip install -r requirements.txt definitely ran and installed backports.lzma. However, I'm guessing it did so in a Python virtualenv, and not in the system's site packages, which scons would be using.

https://docs.travis-ci.com/user/languages/python/#Travis-CI-Uses-Isolated-virtualenvs

Even though we're in a virtual env, we may be able to forcefully use the system's pip (and thus install into site-packages) via:

$ env PATH=$_OLD_VIRTUAL_PATH which pip
/usr/bin/pip

@JonathonReinhart
Copy link
Owner Author

This hasn't been tested on any other architectures, but should be at least really close.

@JonathonReinhart JonathonReinhart merged commit aad6091 into master Jul 16, 2017
@JonathonReinhart JonathonReinhart deleted the 53-dynamic-bcj branch July 16, 2017 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant