staticx: Rework code for PyInstaller pre-5.10 #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Where #236 adapted the new API to the old API with "if pre_510" checks, this takes the opposite approach: Use the new API, and add an adapter class to adapt the old API to the new. Benefits: - No more "if pre_510" checks in the middle of processing code. - Removing the legacy behavior becomes trivial: delete the adapter. Tested: - git clean -fdx test/ - pip install pyinstaller==5.9 - ./test/run_all.sh - pip install pyinstaller==5.10 - ./test/run_all.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where #236 adapted the new API to the old API with
if pre_510checks, this takes the opposite approach: Use the new API, and add an adapter class to adapt the old API to the new.Benefits:
if pre_510checks in the middle of processing code.Tested: