Lazily copy libraries before modifying and rework add_library() #192
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was motivated by noticing this line:
https://github.com/JonathonReinhart/staticx/blob/159fba33/staticx/api.py#L177
I think this could cause some symlinks to get missed if
--strip
was passed.I decided to just re-write this code to be safer, and also only copy libraries lazily before we modify them.
The order of operations looks to be correct: