Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit libraries to check for problematic RPATH/RUNPATH when building #173

Merged
merged 17 commits into from
Oct 4, 2021
Merged

Audit libraries to check for problematic RPATH/RUNPATH when building #173

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
5d1cc54
staticx: Add elf.get_runpath()
JonathonReinhart Apr 24, 2021
1668b5a
staticx: Add StaticxGenerator.audit_library() to check for DT_RUNPATH
JonathonReinhart Oct 3, 2021
c7dbd82
staticx: Check dynamic library in pyinstaller hook
JonathonReinhart Oct 3, 2021
c882a07
staticx: Check for un-fixable RUNPATH in pyinstaller hook
JonathonReinhart Apr 24, 2021
30e36ad
test: Ensure rpath-origin test uses RPATH and not RUNPATH
JonathonReinhart Oct 3, 2021
9b33906
test: add runpath test to ensure staticx detects unacceptable libraries
JonathonReinhart Oct 3, 2021
6dd5b9d
test: Combine rpath/runpath tests
JonathonReinhart Oct 3, 2021
1f02461
test: Combine SConstruct.{rpath,runpath}
JonathonReinhart Oct 3, 2021
1033463
staticx: Add get_rpath()
JonathonReinhart Oct 3, 2021
853cfa3
staticx: Check both RPATH and RUNPATH
JonathonReinhart Oct 3, 2021
2687156
staticx: Add elf.remove_rpath()
JonathonReinhart Oct 3, 2021
79b2af2
staticx: Handle rpath/runpath in add_library by removing it
JonathonReinhart Oct 3, 2021
085ec88
test: Change runpath test to expected success
JonathonReinhart Oct 3, 2021
9cb9798
staticx: Allow harmless RPATH (only) in pyinstaller archive
JonathonReinhart Oct 3, 2021
d2dec78
test: Add funcs.sh with verify_uses_r[un]path
JonathonReinhart Oct 4, 2021
7ff113d
test: Add test to verify staticx catches pyinstalled libs with RUNPATH
JonathonReinhart Oct 4, 2021
8450bc2
Add change log entry for #173
JonathonReinhart Oct 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
staticx: Check for un-fixable RUNPATH in pyinstaller hook
  • Loading branch information
@JonathonReinhart
JonathonReinhart committed Oct 4, 2021
commit c882a076312f7dba1e71a82dde58b2b65d95d188
5 changes: 5 additions & 0 deletions staticx/hooks/pyinstaller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,11 @@ def _add_required_deps(self, lib):
# Silence "you do not have execution permission" warning from ldd
make_executable(lib)

self.sx.audit_library(lib)
# Unfortunately, there's no easy way to fix an UnsupportedRunpathError
# here, because staticx is not about to to modify the library and
# re-pack the PyInstaller archive itself.

# Try to get any dependencies of this file
try:
deps = get_shobj_deps(lib, libpath=[self.tmpdir.name])
Expand Down