Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aarch64 floating point operands support #1359

Merged

Conversation

psi-func
Copy link
Contributor

@psi-func psi-func commented Sep 2, 2024

Implemented initial support for Aarch64 float-point operands in instructions
tested on FMOV, other instructions with this feature are not implemented in triton (float point nature)

@JonathanSalwan
Copy link
Owner

Thx!

What about moving encode_fp_imm into the Immediate class as a new constructor so that the other architectures can benefit of this feature?

Something like this:

Immediate::Immediate(double value, triton::uint32 size) {
    this->setValue(this->encode_fp_imm(value), size);
}

Then, at this line you can just call the new constructor as follow: Immediate imm{op->fp, size};.

@psi-func
Copy link
Contributor Author

psi-func commented Sep 5, 2024

I agree, move feature to Immediate ctor + add endianness check

@JonathanSalwan JonathanSalwan merged commit f675ce2 into JonathanSalwan:dev-v1.0 Sep 6, 2024
26 checks passed
@psi-func psi-func deleted the aarch64/fp_operand_support branch September 6, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants