Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Z3 dependency inconsistency and missing dependencies in Dockerfile #1296

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

m-carrasco
Copy link
Contributor

Hi 👋

I've noticed some difficulties while building Triton from sources using the available Dockerfile. This PR aims to fix them.

  1. Now, Z3 is installed only once using pip to get rid of crashes like Python bindings for tritonToZ3 segfault #1136. This also decreases the time taken to build the Docker image.
  2. The test suite was not executed for the Docker image, which is now.
  3. Some dependencies were missing for the test suite to run successfully.
  4. The Dockerfile was cloning the source code. This prevented us from testing the changes in the CI when working on a branch other than master.

Best regards,
Manuel.

@m-carrasco
Copy link
Contributor Author

m-carrasco commented Dec 4, 2023

The Docker image is built successfully and all test cases are good.

I'm not sure if the remaining failures are triggered by my changes. I missed setting version 4.8.14 for Z3 as in master, instead of the latest release 4.12.2. Could this be triggering the errors?

@JonathanSalwan JonathanSalwan changed the base branch from master to dev-v1.0 December 4, 2023 21:25
@JonathanSalwan
Copy link
Owner

I think those errors are not coming from your commit.

@m-carrasco
Copy link
Contributor Author

Thank you @JonathanSalwan

I've just pushed a commit restoring the previous Z3 version. Let me know if I could do anything else.

@cnheitman
Copy link
Collaborator

Thanks @m-carrasco . It looks like the failures are not related to your commit. I'll merge your request (and take a look at CI to fix those other issues).

@cnheitman cnheitman merged commit 83332bb into JonathanSalwan:dev-v1.0 Dec 5, 2023
24 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants