Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to flutter 3.22.0 #51

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update to flutter 3.22.0 #51

wants to merge 1 commit into from

Conversation

nimr77
Copy link

@nimr77 nimr77 commented May 15, 2024

this just a change on the transactions to use
route.navigator!.userGestureInProgress

since after updating for 3.22.0 there was a removed function:
CupertinoRouteTransitionMixin.isPopGestureInProgress(route)

@nimr77 nimr77 mentioned this pull request May 15, 2024
Closed
JonasWanke
JonasWanke requested changes May 16, 2024
View reviewed changes
Copy link
Owner

@JonasWanke JonasWanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR! The content changes look good, but can you please revert the reorderings inside page_route.dart?

@JonasWanke
Copy link
Owner

I went ahead and merged #54 to support Flutter 3.22, though I can still merge the iOS changes from this PR if you want

@nimr77
Copy link
Author

nimr77 commented May 21, 2024

I went ahead and merged #54 to support Flutter 3.22, though I can still merge the iOS changes from this PR if you want

Ok perfect Go ahead and merge it, Thanks

@JonasWanke
Copy link
Owner

Can you please undo the formatting changes in page_route.dart and resolve the merge conflicts?

@micahmo micahmo mentioned this pull request Jun 7, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasWanke JonasWanke JonasWanke requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@nimr77 nimr77

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nimr77 @JonasWanke