Added get_per_month to get month based consumption data for a given year. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds get_per_month to Eloverblik, to support the issues in homeassistant-eloverblik:
The first one asks for monthly usage data for the current and previous years, and the second one asks for total consumption for the current year. Both can be achieved by fetching monthly usage data for a given year, since the get_total_metering_data() on TimeSeries will return the sum of monthly usages, that is, the usage for the full year, and get_metering_data will return it for each month.
I realise I'm abusing _parse_data a bit here, but I wanted to change as little as possible in the current structure :)