Skip to content
This repository has been archived by the owner on May 13, 2022. It is now read-only.

Allow empty password / no wallet encryption #674

Open
chris-belcher opened this issue Nov 29, 2016 · 0 comments
Open

Allow empty password / no wallet encryption #674

chris-belcher opened this issue Nov 29, 2016 · 0 comments

Comments

@chris-belcher
Copy link
Collaborator

Some people using joinmarket scripts for internal scripting find the encrypted wallet pointless and difficult to code automatically because it uses get_pass()

One way to do this would to try the empty password "" when decrypting and use that if it works.

Another way is to have all scripts have a command-line option to use as the password. This is bad because it could lead to the password ending up .bash_history and would need each script to have this option added.

When creating a wallet with no encryption, a lot of warnings should be given to the user.

peterzen pushed a commit to peterzen/joinmarket that referenced this issue Mar 6, 2017
peterzen pushed a commit to peterzen/joinmarket that referenced this issue Mar 6, 2017
chris-belcher added a commit that referenced this issue Apr 14, 2017
49ec790 fixed no-password option so it now passes the test (chris-belcher)
e40c423 fix test case for empty password (#674) (Peter Banik)
eb83545 Fix logic error (Gero G)
83060af Allow no/empty password (Empty2k12 (Gero G.))

Tree-SHA512: 4e6222efbe78ba24f42a88b804753ad23338beda6cf65909c56129402bee627280e5f6cfde65ac94d8e15dfaaa4395f36cbe427685a67a2cb2033ee3b6705d47
mb300sd pushed a commit to mb300sd/joinmarket that referenced this issue Aug 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant