print directory node info #1231
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamISZ
force-pushed
the
onion-show-motd
branch
from
d8f1c78
to
dedfe2f
Compare
kristapsk
reviewed
Apr 10, 2022
| @@ -1200,6 +1202,8 @@ def process_handshake(self, peerid: str, message: str, | |||
| return | |||
| # We received a valid, accepting dn-handshake. Update the peer. | |||
| peer.update_status(PEER_STATUS_HANDSHAKED) | |||
| # Show the info for the directory to the user, with emphasis: | |||
| self.info_callback("\n\n" + motd + "\n\n") | |||
There was a problem hiding this comment.
We should limit allowed character set here, for example, don't allow ASCII control characters.
There was a problem hiding this comment.
Yes good point. Also there is the question of size. A slight concern I have is, it would be very natural to add e.g. gpg signatures here, but they would represent a big chunk of spam. I guess best practice will be, put a url here where the signature can be found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not urgent, seems open to discussion exactly how to show this, but it should be shown (we may want to do something about
OnionMessageChanel.info_callbackat the same time, by the way).This will go along with a change to JoinMarket-Org/custom-scripts#16 but users don't need to care about that.