Skip to content

Use npm-based colonyToken #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Use npm-based colonyToken #1089

merged 2 commits into from
Sep 23, 2022

Conversation

chmanie
Copy link
Member

@chmanie chmanie commented Sep 21, 2022

To generate the ABIs for ColonyJS, yarn is still necessary due to the colonyToken repo. I created an npm version of the token here: JoinColony/colonyToken#59

This PR points lib/colonyToken to the PR branch but will later be replaced with the master branch of colonyToken.

@chmanie chmanie self-assigned this Sep 21, 2022
@kronosapiens
Copy link
Contributor

@chmanie I've merged colonyToken#59 so you can update this pull request to point to master

@chmanie
Copy link
Member Author

chmanie commented Sep 22, 2022

@kronosapiens Cool thank you! I'm wondering about the other open PRs in colonyToken. Should we also merge some of them before updating the reference?

@kronosapiens
Copy link
Contributor

@chmanie good point, I'll clean up some of those upgrade PRs today

@kronosapiens
Copy link
Contributor

@chmanie I've merged the old dependency upgrades. The new ones (opened in the last 24 hours) are failing so I'll circle back around to those later. I'd say point to colonyToken/master and we can merge this.

kronosapiens
kronosapiens previously approved these changes Sep 23, 2022
@kronosapiens kronosapiens merged commit 1f74585 into develop Sep 23, 2022
@kronosapiens kronosapiens deleted the maint/token-update-npm branch September 23, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants