Skip to content

Add client_company_id parameter to AsyncQuickCollection.get_details#95

Merged
rhythmatician merged 2 commits intobolster-quick-collectionfrom
copilot/sub-pr-94
Jan 5, 2026
Merged

Add client_company_id parameter to AsyncQuickCollection.get_details#95
rhythmatician merged 2 commits intobolster-quick-collectionfrom
copilot/sub-pr-94

Conversation

Copy link
Contributor

Copilot AI commented Jan 5, 2026

The async version of get_details was missing the client_company_id parameter that exists in the sync version, preventing async users from querying client-specific assets with richer client fields.

Changes:

  • Added client_company_id: int | None = None parameter to AsyncQuickCollection.get_details()
  • Implemented conditional logic matching sync version:
    • if not client_company_id: calls get_asset_manager_list.asyncio() for standard assets
    • else: calls get_asset_manager_list_get_2.asyncio() for client-specific assets
  • Updated docstring to match sync implementation

Usage:

async with AsyncQuickCollection(client, asset_ids) as coll:
    # Standard assets (same as before)
    assets = await coll.get_details(search_string="pump")
    
    # Client-specific assets (now supported)
    client_assets = await coll.get_details(
        client_company_id=123,
        search_string="pump"
    )

Both QuickCollection and AsyncQuickCollection now have identical API surface for asset detail retrieval.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: rhythmatician <75549255+rhythmatician@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on asset detail retrieval refactor Add client_company_id parameter to AsyncQuickCollection.get_details Jan 5, 2026
Copilot AI requested a review from rhythmatician January 5, 2026 22:12
@rhythmatician rhythmatician marked this pull request as ready for review January 5, 2026 23:29
@rhythmatician rhythmatician merged commit f8f1e68 into bolster-quick-collection Jan 5, 2026
@rhythmatician rhythmatician deleted the copilot/sub-pr-94 branch January 5, 2026 23:29
rhythmatician added a commit that referenced this pull request Jan 6, 2026
)

* Initial plan

* Add client_company_id parameter to AsyncQuickCollection.get_details

Co-authored-by: rhythmatician <75549255+rhythmatician@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: rhythmatician <75549255+rhythmatician@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants