Enhance file upload functionality and update .gitignore#105
Merged
rhythmatician merged 5 commits intomasterfrom Feb 28, 2026
Merged
Enhance file upload functionality and update .gitignore#105rhythmatician merged 5 commits intomasterfrom
rhythmatician merged 5 commits intomasterfrom
Conversation
…rt multipart/form-data
…ments_post_2 and upload_documents_post_3
…ments and upload_work_item_images
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Qualer SDK’s upload endpoints to correctly send multipart/form-data payloads via httpx, adds tests to validate request construction, and refreshes API docs and repo ignore patterns accordingly.
Changes:
- Add
files: List[File]support to multiple upload endpoints and construct httpxfiles=payloads. - Add unit + integration tests covering multipart request construction and end-to-end upload behavior.
- Update markdown API docs and extend
.gitignorefor temp/backup files.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/qualer_sdk/api/service_order_documents/upload_documents_post_2.py |
Adds multipart files= support and adjusts empty-body JSON parsing. |
src/qualer_sdk/api/service_order_item_documents/upload_documents_post_3.py |
Adds multipart files= support and adjusts empty-body JSON parsing. |
src/qualer_sdk/api/asset_service_records/upload_documents.py |
Adds multipart files= support and adjusts empty-body JSON parsing. |
src/qualer_sdk/api/service_order_items/upload_work_item_images.py |
Adds multipart files= support and handles 204 responses with empty bodies. |
tests/unit/test_upload_endpoints.py |
New unit tests validating _get_kwargs() includes correct files tuples and avoids manual Content-Type. |
tests/integration/test_upload_documents.py |
New integration tests performing real uploads (VCR-marked) to validate end-to-end multipart behavior. |
docs/ServiceOrderDocumentsApi.md |
Updates signature/examples and indicates multipart/form-data. |
docs/ServiceOrderItemDocumentsApi.md |
Updates signature/examples and indicates multipart/form-data. |
docs/ServiceOrderItemsApi.md |
Updates signature/examples and indicates multipart/form-data. |
docs/AssetServiceRecordsApi.md |
Updates signature/examples and indicates multipart/form-data. |
.gitignore |
Ignores temp and .bak files. |
src/qualer_sdk/api/service_order_item_documents/upload_documents_post_3.py
Show resolved
Hide resolved
…uments, upload_documents_post_2, and upload_documents_post_3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve file upload capabilities to support multipart/form-data across multiple APIs. Update .gitignore to exclude temporary and backup files. Fix handling of empty response content in specific upload functions.