Enable parallel test execution and mark slow Excel parsing tests by Copilot · Pull Request #244 · Johnson-Gage-Inspection-Inc/core-api

Copilot · 2026-02-11T06:52:29Z

Test Suite Performance Improvement ✅

Summary

Successfully optimized test suite execution speed by implementing parallel test execution and marking slow tests for optional exclusion.

Performance Results

Test execution time: 30.24s → 12.62s (58% faster!)
Parallel execution: 4 workers automatically scaling to available CPU cores
244 tests pass consistently with improved speed

Changes Implemented

✅ Added pytest-xdist to requirements.txt for parallel test execution
✅ Updated pytest configuration in pyproject.toml:
- Added -n auto to run tests in parallel using all available CPU cores
- Added -m 'not slow' to skip slow tests by default
✅ Marked slow tests with @pytest.mark.slow decorator:
- test_run_refresh_daqbook_offsets_debug (6.73s setup time)
- Excel parsing tests in test_parse.py (1.4-1.5s each)
- Excel parsing tests in test_parse_j1_offsets.py (1.4-1.5s each)
- Excel parsing tests in test_parse_n2_offsets.py (1.1-1.3s each)
- Wire offset parsing tests (0.4-1.2s each)
✅ Updated README with new test commands:
- Run fast tests: pytest -v (default)
- Run all tests: pytest -v -m 'slow or not slow'
- Run only slow tests: pytest -v -m "slow"
- Disable parallel: pytest -v -n 0
✅ Updated CI workflow to run all tests including slow ones
✅ Fixed autouse fixture to only run when slow tests are executed
✅ Improved fixture documentation to clarify explicit dependency requirement

PR Review Feedback Addressed

✅ Updated CI to run all tests with -m 'slow or not slow'
✅ Clarified README label from "Full test suite" to "Default/fast test suite"
✅ Removed autouse=True from fixture to avoid overhead in non-slow test runs
✅ Added clear documentation to fixture explaining dependency requirement

Testing & Verification

✅ Verified default test run skips slow tests and runs in parallel
✅ Verified slow tests can be run explicitly with -m "slow"
✅ Confirmed 4 workers created and tests properly distributed
✅ Code review completed and all feedback addressed
✅ CodeQL security scan passed with no issues
✅ Final verification shows consistent 12-20s execution time
✅ CI now runs all tests including slow ones
✅ Non-slow tests verified to avoid Excel file creation overhead

Security Summary

No security vulnerabilities found by CodeQL scanner.

Original prompt

This section details on the original issue you should resolve

<issue_title>Test suite is getting too slow</issue_title>
<issue_description>We need to identify the slowest tests and speed them up by mocking, optimizing, or skipping.

Lets also make sure that the tests run in parallel in the pytest configuration.</issue_description>

<agent_instructions>Please figure out why our tests run so slow now. Ensure they run in parallel. If there's a test that is important AND slow, mark it with pytest.mark.slow so we can skip it in full test runs, but still run it manually when needed.</agent_instructions>

Comments on the Issue (you are @copilot in this section)

Fixes Test suite is getting too slow #243

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

chatgpt-codex-connector · 2026-02-11T21:13:04Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

Copilot

Pull request overview

This PR speeds up the Python test suite by enabling parallel execution via pytest-xdist and introducing a slow marker so expensive Excel parsing/integration tests can be skipped by default while remaining runnable on-demand.

Changes:

Add pytest-xdist and configure pytest to run tests in parallel (-n auto).
Default to skipping @pytest.mark.slow tests via pytest addopts.
Mark Excel/Office parsing (and related) tests as slow and document updated pytest usage.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`pyproject.toml`	Adds default pytest options for parallelism and skipping `slow` tests; registers the `slow` marker.
`requirements.txt`	Adds `pytest-xdist` dependency.
`README.md`	Updates testing instructions to reflect parallel runs and `slow` selection.
`utils/sync/wire_rolls/tests/test_wire_offsets.py`	Marks Excel parsing parametrized test as `slow`.
`utils/sync/daqbooks/tests/test_parse_n2_offsets.py`	Marks N2 Excel parsing tests as `slow`.
`utils/sync/daqbooks/tests/test_parse_j1_offsets.py`	Marks J1 Excel parsing tests as `slow`.
`utils/sync/daqbooks/tests/test_parse.py`	Imports pytest and marks Excel parsing unit tests as `slow`.
`routes/daqbook_offsets/tests/test_daqbook_offsets_debug.py`	Marks debug sync test as `slow`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pyproject.toml

README.md

utils/sync/daqbooks/tests/test_parse_j1_offsets.py

rhythmatician · 2026-02-11T21:31:13Z

@copilot apply changes based on the comments in this thread

Copilot · 2026-02-11T21:37:03Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

login.microsoftonline.com
- Triggering command: /usr/bin/python /usr/bin/python -u -c import sys;exec(eval(sys.stdin.readline())) (dns block)
pyro.postgres.database.azure.com
- Triggering command: /usr/bin/python /usr/bin/python -u -c import sys;exec(eval(sys.stdin.readline())) (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Copilot

Pull request overview

Copilot reviewed 8 out of 12 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-11T23:54:26Z

.github/workflows/ci.yml

@@ -155,5 +170,15 @@ jobs:
          python -m pip install --upgrade pip
          pip install -r requirements.txt

+      - name: Wait for PostgreSQL to be ready
+        run: |
+          until pg_isready -h localhost -p 5432 -U testuser; do
+            echo "Waiting for PostgreSQL..."
+            sleep 2
+          done
+
+      - name: Run migrations
+        run: python -m alembic upgrade head
+
      - name: Run tests
-        run: pytest -v
+        run: pytest -v -m 'slow or not slow'


The CI job provisions a Postgres service and runs alembic upgrade head, but the test suite’s postgres_container fixture (conftest.py) always starts a Testcontainers-managed Postgres and sets its own DATABASE_URL. That means the service + migration step here are likely unused while tests still incur per-xdist-worker container startup/migrations, which can be slow/flaky. Consider either (a) updating the fixture to reuse DATABASE_URL when provided (CI-managed Postgres), or (b) removing the service/migration steps from this job and letting Testcontainers be the single source of truth.

Copilot · 2026-02-11T23:54:27Z

utils/sync/daqbooks/tests/test_parse_j1_offsets.py

    """Create sample Excel (.xlsm) and CSV files used by tests if not present.

    This avoids committing large binary fixtures and keeps unit tests hermetic.
+
+    Note: This fixture must be explicitly declared as a dependency by test fixtures
+    that need the Excel files (e.g., j1_test_file, k6_test_file). It is not autouse
+    to avoid overhead when running non-slow tests that don't need Excel files.


The fixture docstring says this avoids committing large binary fixtures, but this PR adds J1_0325.xlsm and K6_0824.xlsm under tests/data/. Either remove these committed binaries and rely on the generator, or update the docstring to reflect the new approach (and consider storing generated files under a temp directory to keep tests hermetic).

Copilot · 2026-02-11T23:54:27Z

utils/sync/daqbooks/tests/test_parse_n2_offsets.py

+@pytest.mark.slow
 def test_n2_offsets_not_equal_to_temp(n2_test_file):


These N2 Excel tests are now marked slow, but the referenced fixture file utils/sync/daqbooks/tests/data/N2_1125.xlsm does not appear to exist in the repo, so the fixture will always skip and these tests won’t actually run (even in CI with -m 'slow or not slow'). Consider adding/generating the missing .xlsm test fixture (similar to the J1/K6 generator) or adjusting the tests to use an available fixture.

- Add pytest-xdist to requirements.txt - Configure pytest to run tests in parallel by default (-n auto) - Skip slow tests by default with -m 'not slow' - Mark slow Excel parsing tests with @pytest.mark.slow - Update README with new test commands - Test execution time improved from 30.24s to 12.61s (58% faster) Co-authored-by: rhythmatician <75549255+rhythmatician@users.noreply.github.com>

Use clearer pytest -m 'slow or not slow' instead of -m "" Co-authored-by: rhythmatician <75549255+rhythmatician@users.noreply.github.com>

1. Update CI to run all tests including slow ones with -m 'slow or not slow' 2. Clarify README label from "Full test suite" to "Default/fast test suite" 3. Remove autouse=True from ensure_daqbook_test_fixtures to avoid overhead in non-slow test runs Co-authored-by: rhythmatician <75549255+rhythmatician@users.noreply.github.com>

Co-authored-by: rhythmatician <75549255+rhythmatician@users.noreply.github.com>

…gration step

…tests

Copilot AI assigned Copilot and rhythmatician Feb 11, 2026

Copilot started work on behalf of rhythmatician February 11, 2026 06:52 View session

Copilot AI changed the title ~~[WIP] Improve performance of slow tests in test suite~~ Enable parallel test execution and mark slow Excel parsing tests Feb 11, 2026

Copilot AI requested a review from rhythmatician February 11, 2026 07:02

Copilot finished work on behalf of rhythmatician February 11, 2026 07:02

rhythmatician approved these changes Feb 11, 2026

View reviewed changes

rhythmatician marked this pull request as ready for review February 11, 2026 21:13

Copilot AI review requested due to automatic review settings February 11, 2026 21:13

rhythmatician force-pushed the copilot/optimize-test-suite-speed branch from 11af3fd to f3d269b Compare February 11, 2026 21:13

rhythmatician enabled auto-merge (squash) February 11, 2026 21:13

Copilot started reviewing on behalf of rhythmatician February 11, 2026 21:13 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

pyproject.toml Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

utils/sync/daqbooks/tests/test_parse_j1_offsets.py Show resolved Hide resolved

Copilot started work on behalf of rhythmatician February 11, 2026 21:31 View session

auto-merge was automatically disabled February 11, 2026 21:35
Head branch was pushed to by a user without write access

Copilot AI requested a review from rhythmatician February 11, 2026 21:37

Copilot finished work on behalf of rhythmatician February 11, 2026 21:37

rhythmatician force-pushed the copilot/optimize-test-suite-speed branch from efbb750 to 7690886 Compare February 11, 2026 23:10

rhythmatician enabled auto-merge (squash) February 11, 2026 23:10

rhythmatician requested a review from Copilot February 11, 2026 23:48

Copilot started reviewing on behalf of rhythmatician February 11, 2026 23:49 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

rhythmatician force-pushed the copilot/optimize-test-suite-speed branch from 1c986b6 to 8119da3 Compare February 12, 2026 00:29

Copilot AI and others added 4 commits February 12, 2026 18:11

Improve README test command for running all tests

af9d20a

Use clearer pytest -m 'slow or not slow' instead of -m "" Co-authored-by: rhythmatician <75549255+rhythmatician@users.noreply.github.com>

Update fixture docstring to clarify explicit dependency requirement

1832c5e

Co-authored-by: rhythmatician <75549255+rhythmatician@users.noreply.github.com>

rhythmatician added 3 commits February 12, 2026 18:11

Fix formatting in ensure_daqbook_test_fixtures docstring

38dc8c6

Enhance CI workflow by adding PostgreSQL service configuration and mi…

4439304

…gration step

Refactor postgres_container fixture to improve database handling for …

f00540f

…tests

rhythmatician force-pushed the copilot/optimize-test-suite-speed branch from 8119da3 to f00540f Compare February 13, 2026 00:11

rhythmatician added 4 commits February 12, 2026 20:50

Merge branch 'main' into copilot/optimize-test-suite-speed

bc43d7d

Merge branch 'main' into copilot/optimize-test-suite-speed

6dc3302

Merge branch 'main' into copilot/optimize-test-suite-speed

987fcc5

Merge branch 'main' into copilot/optimize-test-suite-speed

de295a2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable parallel test execution and mark slow Excel parsing tests#244

Enable parallel test execution and mark slow Excel parsing tests#244
Copilot wants to merge 11 commits intomainfrom
copilot/optimize-test-suite-speed

Copilot AI commented Feb 11, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector bot commented Feb 11, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rhythmatician commented Feb 11, 2026

Uh oh!

Copilot AI commented Feb 11, 2026

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 11, 2026

Uh oh!

Copilot AI Feb 11, 2026

Uh oh!

Copilot AI Feb 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@pytest.mark.slow
		def test_n2_offsets_not_equal_to_temp(n2_test_file):

Conversation

Copilot AI commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Suite Performance Improvement ✅

Summary

Performance Results

Changes Implemented

PR Review Feedback Addressed

Testing & Verification

Security Summary

Comments on the Issue (you are @copilot in this section)

Uh oh!

chatgpt-codex-connector bot commented Feb 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rhythmatician commented Feb 11, 2026

Uh oh!

Copilot AI commented Feb 11, 2026

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Feb 11, 2026 •

edited

Loading