Improve comments within function calls #566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #566 +/- ##
==========================================
+ Coverage 97.81% 97.82% +0.01%
==========================================
Files 14 14
Lines 5436 5469 +33
==========================================
+ Hits 5317 5350 +33
Misses 119 119
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
Repo Comparison TestNo diff produced |
matthargett
approved these changes
Sep 4, 2022
| 90210, | ||
| --[[ | ||
| color wheel is time-reversed | ||
| ]] |
There was a problem hiding this comment.
Interesting that it moves these outside of the comma, but maybe not a big deal?
Owner
Author
There was a problem hiding this comment.
Tbh, I think the likelihood of a comment in this particular position (after expression but before the comma) is very low, so not sure it matters too much.
I moved it afterwards for simplicity, but I made an assumption here - let me see if it still works in its current position
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on top of #549
Fixes #565