Fixed issues #926, and #928.

[Lewis-Fam]

Added a double to int Json Converter and added attributes to impacted properties.

[munissor]

FWIW, I like this approach, will fix the serialization issue in a non-breaking way. The public API will keep integers until we can figure out if the change from Spotify is intentional or not.

[Lewis-Fam]

There are a few ways to handle the failing check.

Either, update the attribute tag to:
[JsonConverter(typeof(DoubleToIntConverter), NullValueHandling.Ignore)]

or

Change the converter.

I believe that the latter would a better appraoch. The simplest implementation would be:

public class DoubleToIntConverter : JsonConverter<int>
{
  public override void WriteJson(JsonWriter? writer, int value, JsonSerializer serializer)
  {
    writer?.WriteValue(value);
  }

  public override int ReadJson(JsonReader? reader, Type objectType, int existingValue, bool hasExistingValue,
    JsonSerializer serializer)
  {
    return reader != null ? Convert.ToInt32(reader.Value, CultureInfo.InvariantCulture) : 0;
  }
}

[JohnnyCrazy]

AFAIK, DurationMs is not a double/int problem. It's encoded in an object, see discussion in #926

[Lewis-Fam]

I just tested my use of the api. I can confirm that the double to int works for durationMs. I removed double to int and it threw the serialization exception.

…

On Fri, Jan 26, 2024, 2:25 PM Jonas Dellinger ***@***.***> wrote: AFAIK, DurationMs is not a double/int problem. It's encoded in an object, see discussion in #926 <#926> — Reply to this email directly, view it on GitHub <#942 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AM7XGLOLZ5FTL6HO5QY4XHLYQQNLPAVCNFSM6AAAAABCHQMK52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJSG4YTMMBTG4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[JohnnyCrazy]

Do you have local tracks in the playlist? I think that's the only case where we see objects in the durationMs field.

[narutoshocker]

Hello,

Is this going to be merged soon or do we still have lingering issues?

[JohnnyCrazy]

Will be merged soonish, couple of days max, need to do some additional testing.