Fixing #607 + Refactoring#608
Conversation
Added me/episodes and done some refactoring
Fixing the remove of epsides.
JohnnyCrazy
left a comment
There was a problem hiding this comment.
Looks good except those 2 things, thank you! 👍🏼
JohnnyCrazy
left a comment
There was a problem hiding this comment.
Found two more small things, I think then we should be good to go! 👍🏼
| /// </summary> | ||
| /// <value></value> | ||
| [QueryParam("uris")] | ||
| public IList<string> URIs { get; } |
There was a problem hiding this comment.
I think this should be ids instead of uris. See: https://developer.spotify.com/documentation/web-api/reference/#endpoint-save-episodes-user
| namespace SpotifyAPI.Web | ||
| { | ||
| public class LibraryEpisodesRequest : RequestParams | ||
| { |
There was a problem hiding this comment.
The parameter market is missing here, see https://developer.spotify.com/documentation/web-api/reference/#endpoint-get-users-saved-episodes
|
@JohnnyCrazy should be OK now :) Sorry for the delay! |
|
Looks good! I will have one more detailed look and run some tests this week :) No worries regarding the delay, I'm happy you contributed! 👍🏼 |
|
Sorry for the delay here, looks very good! Thank you for your contribution 🙏 👍🏼 |
Added me/episodes and done some refactoring