SimpleRetryHandler - sleep now uses CancellationToken #1032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Actually, I've just noticed that this is a very minor breaking change, as previous method groups that are passed in could have an overload that took in a cancellation token, so it becomes ambiguous with the new overload on Booo C#! So, I guess it's either: allow the minor breaking change or don't overload the constructor and instead set the sleeper with a method or something? But that seems a bit mad? |
Owner
|
Hi, Thanks for that, looks like a good change to have! Could you rebase your changes on the latest master so we can get the CI to pass? LGTM then! |
Contributor
Author
|
Cool! All done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hope this is okay!
closes #1031