Added Handle protocol to get asynchronous output#30
Open
gwikiera wants to merge 2 commits intoJohnSundell:masterfrom
Open
Added Handle protocol to get asynchronous output#30gwikiera wants to merge 2 commits intoJohnSundell:masterfrom
Handle protocol to get asynchronous output#30gwikiera wants to merge 2 commits intoJohnSundell:masterfrom
Conversation
|
This looks good. @JohnSundell would you like any changes before merging this? We could then add the implementation from @SteveBarnegren in #22 so that users can use FileHandle.standardOuput & FileHandle.standardError. I've tested out #22 locally. private extension FileHandle {
var shouldBeClosed: Bool {
return self !== FileHandle.standardOutput &&
self !== FileHandle.standardError &&
self !== FileHandle.standardInput
}
}
extension FileHandle: Handle {
public func handle(data: Data) {
write(data)
}
public func endHandling() {
if shouldBeClosed { closeFile() }
// alternative using naming from #22
// if !isStandard { closeFile() }
}
} |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've created a protocol
Handleto handle command output asynchronously. All previouslyFileHandlearguments ofshellOutmethods have been replaced byHandle.FileHandleimplementsHandleso it's completely backward compatible.StringHandleconvertsDataoutput intoStringone.It fixes #11.