Skip to content

FEATURE NMH-133: Rename products in search [skip-test] #12998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 8, 2022
Merged

FEATURE NMH-133: Rename products in search [skip-test] #12998

merged 2 commits into from
Nov 8, 2022

Conversation

KshitizGIT
Copy link
Contributor

Jira Ticket NMH-133

@KshitizGIT KshitizGIT changed the title FEATURE NMH-133: Rename products in search FEATURE NMH-133: Rename products in search [skip-test] Oct 31, 2022
pabla
pabla reviewed Nov 3, 2022
View reviewed changes
Copy link
Contributor

@pabla pabla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember, that we should support old and new product names on frontend and backend (search):
https://nlp.johnsnowlabs.com/models?edition=Healthcare+NLP+4.1
https://nlp.johnsnowlabs.com/models?edition=Spark+NLP+Healthcare+4.1

@KshitizGIT
Copy link
Contributor Author

Remember, that we should support old and new product names on frontend and backend (search): https://nlp.johnsnowlabs.com/models?edition=Healthcare+NLP+4.1 https://nlp.johnsnowlabs.com/models?edition=Spark+NLP+Healthcare+4.1

@pabla , Why do we need to support both if every models will use the new name after this PR ?

@KshitizGIT
Copy link
Contributor Author

Remember, that we should support old and new product names on frontend and backend (search): https://nlp.johnsnowlabs.com/models?edition=Healthcare+NLP+4.1 https://nlp.johnsnowlabs.com/models?edition=Spark+NLP+Healthcare+4.1

@pabla , This PR allows supporting both variants on the search service

@pabla pabla requested a review from maziyarpanahi November 8, 2022 07:29
@maziyarpanahi maziyarpanahi merged commit 0285f6d into JohnSnowLabs:master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pabla pabla pabla approved these changes

@maziyarpanahi maziyarpanahi maziyarpanahi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KshitizGIT @pabla @maziyarpanahi