Skip to content

Conversation

JohT
Copy link
Owner

@JohT JohT commented Aug 24, 2024

🚀 Feature

⚙️ Optimization

🛠 Fix

  • Fix namespaces containing version numbers with pnpm. With an "ExternalModule.globalFqn" like react-router-6.24.1/node_modules/.pnpm/@types+react@18.2.18/node_modules/@types/react/index.d.ts it is much more reliable to extract the namespace (here @types) after the last occurrence of /node_modules/. Otherwise, a version number could be interpreted as the namespace.

@JohT JohT force-pushed the feature/detect-and-mark-test-modules-for-typescript branch from d5e4c93 to 5910b11 Compare August 24, 2024 14:49
@JohT JohT self-assigned this Aug 24, 2024
@JohT JohT force-pushed the feature/detect-and-mark-test-modules-for-typescript branch 2 times, most recently from 9715005 to 920a5b5 Compare August 24, 2024 16:49
@JohT JohT marked this pull request as ready for review August 24, 2024 16:56
@JohT JohT force-pushed the feature/detect-and-mark-test-modules-for-typescript branch from 920a5b5 to f44ecf2 Compare August 24, 2024 17:16
@JohT JohT force-pushed the feature/detect-and-mark-test-modules-for-typescript branch from afeabae to a1fae99 Compare August 24, 2024 18:35
@JohT JohT changed the title Detect and mark Typescript test modules Detect, mark and filter test related modules in Typescript Aug 24, 2024
@JohT JohT changed the title Detect, mark and filter test related modules in Typescript Detect, mark and filter test related modules in Typescript analysis Aug 24, 2024
@JohT JohT merged commit b2e5480 into main Aug 24, 2024
@JohT JohT deleted the feature/detect-and-mark-test-modules-for-typescript branch August 24, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant