Skip to content
This repository was archived by the owner on Apr 29, 2022. It is now read-only.

Conversation

@patrickhacens
Copy link

upading read me with info from issue #93

@SeppPenner
Copy link
Contributor

Looks good for me. Some small changes from my side:

  • I would close all sentences with a dot
  • Describe what PROBLEMATIC_COMPONENT stands for and provide an example, e.g. "PROBLEMATIC_COMPONENT here means a specific chart component like ChartJsLineChart"
  • "For more information, check out our known issues page" (With the link of course as you already have it)

Before you change something here, please wait for @Joelius300 remarks, too. He might have some more ideas.

And thank you for the pull request. I wanted to do that but didn't have the time yet :D

@Joelius300
Copy link
Owner

I approve the comments of @SeppPenner. I can only emphasize that the example for the ReferenceConverter stuff has to be very clear.

@SeppPenner
Copy link
Contributor

@Joelius300 I integrated this into #98 (Because both are changes in the readme) to get this done.

@Joelius300
Copy link
Owner

Since there were a few changes for the readme that could be done together, this pull request is now unnecessary since your work has been reused in #98 :)

@Joelius300 Joelius300 closed this Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants