Need to add --name option before LibraryName.#1
Open
joshuapinter wants to merge 1 commit intoJoeStanton:masterfrom
joshuapinter:patch-1
Open
Need to add --name option before LibraryName.#1joshuapinter wants to merge 1 commit intoJoeStanton:masterfrom joshuapinter:patch-1
--name option before LibraryName.#1joshuapinter wants to merge 1 commit intoJoeStanton:masterfrom
joshuapinter:patch-1
Conversation
Ideally, I think we should change this to take in the LibraryName without the `--name` option since it's not really an option but this is a stop gap until that PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ideally, I think we should change this to take in the LibraryName without the
--nameoption since it's not really an option but this is a stop gap until that PR.