fixes #16257, cloning of sparse arrays

JoeNemo · Jan 4, 2016 · 4c39c14 · 4c39c14
1 parent a19a1c7
commit 4c39c14
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/_base/lang.js b/_base/lang.js
@@ -502,7 +502,7 @@ define(["./kernel", "../has", "../sniff"], function(dojo, has){
 				r = [];
 				for(i = 0, l = src.length; i < l; ++i){
 					if(i in src){
-						r.push(lang.clone(src[i]));
+						r[i] = lang.clone(src[i]);
 					}
 				}
 				// we don't clone functions for performance reasons

diff --git a/tests/unit/_base/lang.js b/tests/unit/_base/lang.js
@@ -312,6 +312,8 @@ define([
 			};
 
 			assert.deepEqual(obj1, lang.clone(obj1));
+			obj1.baz.b[6] = "c"; // intentional sparse populatation
+			assert.deepEqual(obj1.baz.b, lang.clone(obj1).baz.b, "Sparse arrays should be equal");
 		},
 
 		'.delegate': function () {